Repository navigation
Conversation
Add optional extension exclusions to the local block cache so data files can remain cacheable without caching BLOB bodies. Preserve write and delete invalidation for excluded files, and cover memory, disk and shared-disk reads with regression tests. Closes apache#971 Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Use slash-separated paths for FileIO cache classification while retaining native paths for direct filesystem operations. Keep all exclusion and invalidation assertions enabled on Windows. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
JeonDaehong
reviewed
Nov 2, 2026
Add an opt-in Rust cache attachment method and pass extension exclusions from C options without changing existing Rust or C signatures. Reuse the local-cache parser and cover external cache bypass, default compatibility, and write/delete invalidation in Rust and C tests. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
JeonDaehong
approved these changes
Nov 3, 2026
JeonDaehong
left a comment
JeonDaehong
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding the external cache path. The new C binding test and the exclusion tests pass for me on c089978.
JingsongLi
reviewed
Nov 5, 2026
A filesystem alias with trailing whitespace could fill the block cache for an excluded file because matching used the caller's path. Check the normalized OpenDAL path before looking up blocks for full and range reads. Cover filesystem aliases and a provider that maps a logical data file to an excluded BLOB. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
JeonDaehong
approved these changes
Nov 6, 2026
Contributor
|
I’m not sure if this issue is still relevant; we’ve already implemented |
Member
Author
|
Thanks, agreed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #971.
Local caching supports broad data selection or fixed
structured-dataexclusions, but cannot exclude configurable file extensions.Brief change log
local-cache.exclude-extensionsto exclude BLOB or other extensions.Tests
API and Format
Adds one catalog option. Storage and cache formats are unchanged.
Documentation
Updated the local-cache configuration guide.